-
Notifications
You must be signed in to change notification settings - Fork 28
♻️ web-server: Refactor products domain #7263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ web-server: Refactor products domain #7263
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7263 +/- ##
==========================================
+ Coverage 87.08% 87.11% +0.03%
==========================================
Files 1685 1689 +4
Lines 65492 65523 +31
Branches 1119 1119
==========================================
+ Hits 57031 57081 +50
+ Misses 8143 8124 -19
Partials 318 318
Continue to review full report in Codecov by Sentry.
|
694fdaa
to
4976951
Compare
07d794e
to
db2c77c
Compare
db2c77c
to
d98a77b
Compare
2e85962
to
f072c21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the initiative, very nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
packages/models-library/src/models_library/api_schemas_webserver/product.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_products_prices.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/products/_rest.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the effort! 🚀
|
What does this PR do?
This PR refactors the
simcore_service_webserver.products
domain, improving its structure and organization while extending test coverage of that domain to over 90%.✨ Key Changes:
Refactored package structure to follow a layered architecture:
_repository
_service
,products_service
(public)_models
,models
(public)Annotated
web
):_web_events
: Definesweb.Application
event slots_web_middlewares
: Handlesweb.Application
middlewares_web_helpers
: Provides helper functions wrapping the service layer foraiohttp.web
products_web
(public): Exposes some helpers_rest
_invitation_rest
to theinvitations
domainweb-api v0.59 -> v0.60
_rest_schemas
are remaining schemas that were not inmodels_library.api_schemas_webserver.product
_rpc
plugin
Extended test coverage: Increased coverage to over 90% for the
products
domain.🔍 Expected Public Interface Usage:
What's Next?
Further improvements, as outlined in #7275, will follow in subsequent PRs.
Related issue/s
How to test
Driving test
Dev-ops
None