-
Notifications
You must be signed in to change notification settings - Fork 28
♻️🎨 web-server: enhances product
domain
#7294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️🎨 web-server: enhances product
domain
#7294
Conversation
1db3b7a
to
7f78cb5
Compare
product
domain
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7294 +/- ##
==========================================
+ Coverage 87.41% 89.48% +2.07%
==========================================
Files 1693 1450 -243
Lines 65873 57544 -8329
Branches 1121 614 -507
==========================================
- Hits 57580 51496 -6084
+ Misses 7973 5877 -2096
+ Partials 320 171 -149
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
f59cbbb
to
fed33cd
Compare
fed33cd
to
3cfc3ce
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
packages/postgres-database/src/simcore_postgres_database/utils_payments.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice Pedro! Thanks a lot for the effort. I would like to discuss with you again about the design of these subdomains. I don't see where we don't align 🙂
What do these changes do?
This PR is a follow up from #7263 where we increased coveraged and restructured the
product
domain in thewebserver
. This PR does a number of a upgrades of the functionality and small changes in the structureChanges in simcore-postgres-database
utils_products*.py
migrated from aiopg to asyncpgerrors
->aiopg_errors
because those are not raised by sqlalchemy.exc.asyncio functionalityChanges in web-server's
product
domainBaseRepository
ProductRepository
CreditResult
,ProductStripIfon
andPaymentFields
Changes in web-server's
api-keys
domain@giancarloromeo @bisgaard-itis please carefully review these changes
test_prune_expired_api_keys_task_is_triggered
) while also calling to delete explicitly. The solution was creating a new fixturedisabled_setup_garbage_collector
to disabling GCRelated issue/s
product
domain #7294How to test
Dev-ops