-
Notifications
You must be signed in to change notification settings - Fork 28
🎨 [Frontend] Feature: Hide username #7406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] Feature: Hide username #7406
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7406 +/- ##
==========================================
+ Coverage 87.31% 88.36% +1.05%
==========================================
Files 1712 1381 -331
Lines 66430 53976 -12454
Branches 1125 615 -510
==========================================
- Hits 58004 47697 -10307
+ Misses 8106 6108 -1998
+ Partials 320 171 -149
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…sparc-simcore into feature/hide-username
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 81c58df |
|
Co-authored-by: Pedro Crespo-Valero <[email protected]>
What do these changes do?
Following #7402 and #7408, this PR exposes the
hideUsername
privacy setting.When all three searchable fields are hidden, a warning message is shown explaining that "If all searchable fields are hidden, you will not be findable." Also, next to the user data fields a small eye icon is shown representing which fields are visible, for now I prefer not to have these icons interactive.
Related issue/s
How to test
Dev-ops checklist