Skip to content

🎨 [Frontend] Feature: Hide username #7406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 56 commits into from
Mar 24, 2025

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Mar 21, 2025

What do these changes do?

Following #7402 and #7408, this PR exposes the hideUsername privacy setting.

When all three searchable fields are hidden, a warning message is shown explaining that "If all searchable fields are hidden, you will not be findable." Also, next to the user data fields a small eye icon is shown representing which fields are visible, for now I prefer not to have these icons interactive.

HideUsername

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Mar 21, 2025
@odeimaiz odeimaiz added this to the The Awakening milestone Mar 21, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Mar 21, 2025
@odeimaiz odeimaiz marked this pull request as ready for review March 21, 2025 13:23
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.36%. Comparing base (180355d) to head (66e3490).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7406      +/-   ##
==========================================
+ Coverage   87.31%   88.36%   +1.05%     
==========================================
  Files        1712     1381     -331     
  Lines       66430    53976   -12454     
  Branches     1125      615     -510     
==========================================
- Hits        58004    47697   -10307     
+ Misses       8106     6108    -1998     
+ Partials      320      171     -149     
Flag Coverage Δ *Carryforward flag
integrationtests 64.19% <100.00%> (-1.09%) ⬇️ Carriedforward from 6ea4ba7
unittests 87.45% <85.71%> (+0.98%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 92.05% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.11% <100.00%> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling ∅ <ø> (∅)
catalog 92.14% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director ∅ <ø> (∅)
director_v2 91.27% <ø> (-0.02%) ⬇️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker ∅ <ø> (∅)
storage 84.71% <80.64%> (+0.30%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.53% <100.00%> (-0.31%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 180355d...66e3490. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 24, 2025
@odeimaiz
Copy link
Member Author

@Mergifyio queue

Copy link
Contributor

mergify bot commented Mar 24, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 81c58df

@mergify mergify bot merged commit 81c58df into ITISFoundation:master Mar 24, 2025
58 checks passed
@odeimaiz odeimaiz deleted the feature/hide-username branch March 24, 2025 12:16
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants