Skip to content

🎨 web-api: Add privacy Field to Profile Endpoints and Retire Legacy Entrypoint #7408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 24, 2025

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Mar 21, 2025

What do these changes do?

ReDoc

In #7402 I forgot to add the new privacy policy to some models.

Rewritten Entries:

  • 🎨 Add missing privacy field to GET v0/me response and PATCH v0/me request payload
    image

  • 🗑️ Retire legacy PUT v0/me (update_my_profile) endpoint

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit/**/test*user*.py

Dev-ops

@pcrespov pcrespov self-assigned this Mar 21, 2025
@pcrespov pcrespov added this to the The Awakening milestone Mar 21, 2025
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Mar 21, 2025
@pcrespov pcrespov requested a review from odeimaiz March 21, 2025 12:57
@pcrespov pcrespov marked this pull request as ready for review March 21, 2025 12:57
@pcrespov pcrespov changed the title 🎨 Add privacy Field to Profile Endpoints and Retire Legacy Entrypoint 🎨 web-api: Add privacy Field to Profile Endpoints and Retire Legacy Entrypoint Mar 21, 2025
@pcrespov pcrespov enabled auto-merge (squash) March 21, 2025 12:58
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.61%. Comparing base (445c6de) to head (1b0a1db).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7408      +/-   ##
==========================================
+ Coverage   85.73%   88.61%   +2.88%     
==========================================
  Files        1712     1482     -230     
  Lines       66507    59071    -7436     
  Branches     1131      615     -516     
==========================================
- Hits        57020    52348    -4672     
+ Misses       9165     6552    -2613     
+ Partials      322      171     -151     
Flag Coverage Δ
integrationtests 65.27% <100.00%> (-0.06%) ⬇️
unittests 86.92% <100.00%> (+2.24%) ⬆️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 92.05% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.11% <100.00%> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.14% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.61% <ø> (ø)
director_v2 91.27% <ø> (-0.03%) ⬇️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.08% <ø> (-0.04%) ⬇️
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.12% <ø> (ø)
storage 84.63% <ø> (+0.03%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.88% <100.00%> (+5.50%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 445c6de...1b0a1db. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@pcrespov pcrespov force-pushed the is38/missing-username-privacy branch from da0e6d6 to a0c3bb2 Compare March 21, 2025 15:19
@pcrespov pcrespov requested a review from bisgaard-itis March 21, 2025 15:19
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@odeimaiz
Copy link
Member

I believe you also need to update the ToUserUpdateDB class

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pcrespov pcrespov force-pushed the is38/missing-username-privacy branch from f07de3f to ea59980 Compare March 24, 2025 09:27
@pcrespov pcrespov disabled auto-merge March 24, 2025 11:03
@pcrespov pcrespov merged commit fb29a91 into ITISFoundation:master Mar 24, 2025
94 checks passed
@pcrespov pcrespov deleted the is38/missing-username-privacy branch March 24, 2025 11:03
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants