-
Notifications
You must be signed in to change notification settings - Fork 28
✨Storage: batchDelete #7450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Storage: batchDelete #7450
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7450 +/- ##
==========================================
- Coverage 87.40% 87.25% -0.15%
==========================================
Files 1729 1563 -166
Lines 66830 63071 -3759
Branches 1133 899 -234
==========================================
- Hits 58410 55033 -3377
+ Misses 8099 7778 -321
+ Partials 321 260 -61
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
145a0c1
to
0b0c018
Compare
0b0c018
to
0708150
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LRT 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
452cc75
to
0bea039
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! thx
0bea039
to
9433757
Compare
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 5f1c5d7 |
What do these changes do?
This PR adds a batch delete to the webserver REST API.
This then calls into storage via RPC and then into the storage worker via Celery.
As it is, currently this cannot be cancelled once started.
@odeimaiz it should then be ready for frontend implementation.
Related issue/s
How to test
Dev-ops checklist