Skip to content

✨Storage: batchDelete #7450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 1, 2025
Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 31, 2025

What do these changes do?

This PR adds a batch delete to the webserver REST API.

This then calls into storage via RPC and then into the storage worker via Celery.
As it is, currently this cannot be cancelled once started.

@odeimaiz it should then be ready for frontend implementation.

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.25%. Comparing base (bc543e5) to head (9433757).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7450      +/-   ##
==========================================
- Coverage   87.40%   87.25%   -0.15%     
==========================================
  Files        1729     1563     -166     
  Lines       66830    63071    -3759     
  Branches     1133      899     -234     
==========================================
- Hits        58410    55033    -3377     
+ Misses       8099     7778     -321     
+ Partials      321      260      -61     
Flag Coverage Δ
integrationtests 65.18% <40.00%> (+<0.01%) ⬆️
unittests 86.37% <89.74%> (-0.20%) ⬇️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 92.05% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.42% <0.00%> (-0.06%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.73% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.82% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.96% <ø> (+0.09%) ⬆️
director_v2 91.30% <ø> (ø)
dynamic_scheduler 97.35% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.85% <ø> (-0.28%) ⬇️
storage 86.83% <100.00%> (+0.18%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.91% <100.00%> (+0.06%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc543e5...9433757. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg changed the title initial Storage: batchDelete Mar 31, 2025
@sanderegg sanderegg changed the title Storage: batchDelete ✨Storage: batchDelete Mar 31, 2025
@sanderegg sanderegg added this to the The Awakening milestone Mar 31, 2025
@sanderegg sanderegg added a:storage issue related to storage service a:webserver issue related to the webserver service labels Mar 31, 2025
@sanderegg sanderegg self-assigned this Mar 31, 2025
@sanderegg sanderegg force-pushed the storage/batchDelete branch 2 times, most recently from 145a0c1 to 0b0c018 Compare March 31, 2025 12:46
@sanderegg sanderegg requested a review from odeimaiz March 31, 2025 12:47
@sanderegg sanderegg marked this pull request as ready for review March 31, 2025 12:48
@sanderegg sanderegg requested a review from bisgaard-itis March 31, 2025 12:48
@sanderegg sanderegg force-pushed the storage/batchDelete branch from 0b0c018 to 0708150 Compare March 31, 2025 13:24
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LRT 💪

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sanderegg sanderegg force-pushed the storage/batchDelete branch from 452cc75 to 0bea039 Compare April 1, 2025 07:48
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! thx

@sanderegg sanderegg force-pushed the storage/batchDelete branch from 0bea039 to 9433757 Compare April 1, 2025 09:53
Copy link

sonarqubecloud bot commented Apr 1, 2025

@sanderegg sanderegg added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 1, 2025
@sanderegg
Copy link
Member Author

@mergify queue

Copy link
Contributor

mergify bot commented Apr 1, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 5f1c5d7

@mergify mergify bot merged commit 5f1c5d7 into ITISFoundation:master Apr 1, 2025
93 of 95 checks passed
@sanderegg sanderegg deleted the storage/batchDelete branch April 1, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖-automerge marks PR as ready to be merged for Mergify a:storage issue related to storage service a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch operations delete
5 participants