-
Notifications
You must be signed in to change notification settings - Fork 28
🎨 [Frontend] Enh: batch delete files #7458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] Enh: batch delete files #7458
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7458 +/- ##
==========================================
- Coverage 87.39% 87.24% -0.16%
==========================================
Files 1728 1562 -166
Lines 66821 63062 -3759
Branches 1133 899 -234
==========================================
- Hits 58401 55016 -3385
+ Misses 8099 7786 -313
+ Partials 321 260 -61
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…core into feature/batch-delete-files
…rc-simcore into feature/batch-delete-files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
- What if I select them all and the total exceeds 1000? Should there be some progress indicator for the deletion process?
- Can you cancel/interrupt deletion in that case?
I'll think about it 👍 |
What do these changes do?
In this PR, the frontend uses the new batch delete endpoint, for deleting one or more files/paths
Bonus
Related issue/s
How to test
Dev-ops checklist