-
Notifications
You must be signed in to change notification settings - Fork 28
🔨 Removes unused validation #7468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Removes unused validation #7468
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7468 +/- ##
===========================================
- Coverage 87.39% 68.90% -18.50%
===========================================
Files 1735 738 -997
Lines 66976 34479 -32497
Branches 1136 168 -968
===========================================
- Hits 58535 23758 -34777
- Misses 8120 10663 +2543
+ Partials 321 58 -263
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bisgaard-itis @giancarloromeo not sure what you were trying to do there, but this was failing.
Also I think we discussed of moving around the ProgressBarData instead of the ProgressReport. Please keep it up, create an issue
What do these changes do?
Removes unused and faulty validation
Related issue/s
How to test
Dev-ops checklist