Skip to content

🔨 Removes unused validation #7468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Apr 3, 2025

What do these changes do?

Removes unused and faulty validation

image

Related issue/s

How to test

Dev-ops checklist

@pcrespov pcrespov requested a review from sanderegg as a code owner April 3, 2025 10:02
@pcrespov pcrespov self-assigned this Apr 3, 2025
@pcrespov pcrespov added this to the The Awakening milestone Apr 3, 2025
@pcrespov pcrespov requested review from bisgaard-itis, giancarloromeo and matusdrobuliak66 and removed request for bisgaard-itis April 3, 2025 10:02
@pcrespov pcrespov enabled auto-merge (squash) April 3, 2025 10:02
Copy link

sonarqubecloud bot commented Apr 3, 2025

Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.90%. Comparing base (1a322be) to head (e2c3795).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (1a322be) and HEAD (e2c3795). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (1a322be) HEAD (e2c3795)
unittests 30 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7468       +/-   ##
===========================================
- Coverage   87.39%   68.90%   -18.50%     
===========================================
  Files        1735      738      -997     
  Lines       66976    34479    -32497     
  Branches     1136      168      -968     
===========================================
- Hits        58535    23758    -34777     
- Misses       8120    10663     +2543     
+ Partials      321       58      -263     
Flag Coverage Δ
integrationtests 65.16% <ø> (-0.03%) ⬇️
unittests 87.28% <100.00%> (+0.71%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.59% <ø> (-12.69%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage 87.28% <100.00%> (+0.44%) ⬆️
webclient ∅ <ø> (∅)
webserver 59.13% <ø> (-26.77%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a322be...e2c3795. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bisgaard-itis @giancarloromeo not sure what you were trying to do there, but this was failing.
Also I think we discussed of moving around the ProgressBarData instead of the ProgressReport. Please keep it up, create an issue

@pcrespov pcrespov merged commit c05552a into ITISFoundation:master Apr 3, 2025
90 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants