Skip to content

Add tensor factorizations through MatrixAlgebraKit #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Mar 17, 2025

Conversation

lkdvos
Copy link
Contributor

@lkdvos lkdvos commented Mar 12, 2025

Since MatrixAlgebraKit is now actually released, here's a second attempt at adding in the factorizations.

To do

  • decide if names are okay
  • decide how and if mapping kwargs, or dealing with algorithm selection in general
  • decide if we want to distinguish between ishermitian, and if so, if we care about the type stability.
  • decide how we want to handle in-place/non-in-place operations.
  • wait for fix for segfault
  • add nullspaces

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 98.71795% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.02%. Comparing base (2c46a8e) to head (eb6276f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/factorizations.jl 98.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   94.60%   95.02%   +0.41%     
==========================================
  Files          15       15              
  Lines         371      422      +51     
==========================================
+ Hits          351      401      +50     
- Misses         20       21       +1     
Flag Coverage Δ
docs 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos
Copy link
Contributor Author

lkdvos commented Mar 12, 2025

I temporarily disabled the lq tests since apparently MatrixAlgebraKit is causing segfaults (oopsie) 😉
Should be fixed once QuantumKitHub/MatrixAlgebraKit.jl#10 is resolved.

@lkdvos lkdvos requested a review from mtfishman March 12, 2025 21:04
@mtfishman
Copy link
Member

Looks like a great start! Those are all good issues to discuss.

@lkdvos lkdvos changed the title [WIP] Add tensor factorizations through MatrixAlgebraKit Add tensor factorizations through MatrixAlgebraKit Mar 17, 2025
@lkdvos lkdvos requested a review from mtfishman March 17, 2025 13:41
@lkdvos
Copy link
Contributor Author

lkdvos commented Mar 17, 2025

If tests pass, I think this should now be good to go. I've addressed all comments we discussed I think, and all todo's are done.

@mtfishman
Copy link
Member

Really great, thanks @lkdvos. Looks like you guys did a nice job making a simple and comprehensive factorization interface in MatrixAlgebraKit.jl. I'm also happy to see the fusedims/splitdims interface pay off to make it easy to implement matricized tensor factorizations.

@mtfishman mtfishman merged commit 28577a3 into ITensor:main Mar 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants