-
Notifications
You must be signed in to change notification settings - Fork 2
Add tensor factorizations through MatrixAlgebraKit #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 94.60% 95.02% +0.41%
==========================================
Files 15 15
Lines 371 422 +51
==========================================
+ Hits 351 401 +50
- Misses 20 21 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I temporarily disabled the |
Looks like a great start! Those are all good issues to discuss. |
If tests pass, I think this should now be good to go. I've addressed all comments we discussed I think, and all todo's are done. |
Really great, thanks @lkdvos. Looks like you guys did a nice job making a simple and comprehensive factorization interface in MatrixAlgebraKit.jl. I'm also happy to see the |
Since MatrixAlgebraKit is now actually released, here's a second attempt at adding in the factorizations.
To do
kwargs
, or dealing with algorithm selection in generalishermitian
, and if so, if we care about the type stability.