Exit policy #3785
Merged
Exit policy #3785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
added
networking
outbound-governor
nfrisby
reviewed
Jun 2, 2022
coot
force-pushed
the
coot/exit-policy
branch
3 times, most recently
from
c2b8be7 to
56742ea
Compare
Merged
bolt12
approved these changes
Jun 20, 2022
coot
commented
Jul 4, 2022
By hiding `peerconn` we can simplify diffusion types. This is required if we want to add result type of protocols (on the initiator side).
ExitPolicy governs the delay for reconnecting either if any of the mini-protocol exists cleanly or throws an exception.
When any of the mini-protocol exits (either with an error or otherwise), we reactivation delay which is used by the outbound governor. It is expected that multiple mini-protocol exits roughly at the same time, e.g. in hot to warm transition `chain-sync`, `block-fetch` and `tx-submission` will terminate around the same time. For this reason the `setActivateTimes` is taking the maximum of the existing connect time and the new one, as well as the `ReconnectDelay` is an additive monoid.
The outbound governor needs to know the reconnection delay when a connection errors (asynchronous demotion to cold peer). We use the `ExitPolicy` `epErrorDelay`, which is set to 10 seconds. This patch fixes a bunch of TODOs.
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 11, 2022
3785: Exit policy r=coot a=coot Resolves #3779 Co-authored-by: Marcin Szamotulski <[email protected]>
|
Build failed: |
9 tasks
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 13, 2022
3893: Document flakiness of WallClock tests r=amesgen a=amesgen # Description Reported by `@coot` (found in #3785 (comment)), thanks! Co-authored-by: Alexander Esgen <[email protected]>
This was referenced Oct 28, 2022
iohk-bors bot
added a commit
that referenced
this pull request
Nov 9, 2022
4120: Cherry picked network changes for cardano-node-1.35.5 release r=coot a=coot This cherry-picked patches from the following PRs: * #3794 * #3844 * #3785 * #3904 * #3915 * #3852 * #3970 * #3979 * #4015 * #4067 * #4004 * #4086 * #4113 * #4106 * #4127 * #4103 Also cherry-picked almost all the commits which modify GitHub actions: * 18c5244 Run GitHub Actions on pull requests * 3adf5a9 Use newer version of io-sim * ee9b7a6 Fix GH Actions Windows CI: switch from pkgconf to pkg-config * e6cf074 github-actions: use `ubuntu-latest` * 9a8b959 Updated versions of github actions * fc8f8f0 Fix GH Actions Windows CI caching * 7f07c40 Windows Github Actions now use MSYS2 * b21a7ce Fix chocolatey CI error * #4134 TODO: * [x] bump versions of packages * [x] input-output-hk/cardano-haskell-packages#84 Co-authored-by: Mark Tullsen <[email protected]> Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3779