Skip to content

Updated io-sim & typed-protocols #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2022
Merged

Updated io-sim & typed-protocols #4103

merged 3 commits into from
Nov 7, 2022

Conversation

coot
Copy link
Contributor

@coot coot commented Oct 26, 2022 •
edited
Loading

Description

Updated io-sim, io-classes and strict-stm.

TODO:

Checklist

  • Branch
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • New tests are added if needed and existing tests are updated
    • If this branch changes Consensus and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@coot coot marked this pull request as ready for review October 26, 2022 11:33
@coot coot changed the title Updated io-sim, io-classes and strict-stm Updated io-sim & typed-protocols Oct 26, 2022
amesgen
amesgen reviewed Oct 26, 2022
View reviewed changes
@coot coot force-pushed the coot/io-sim branch 2 times, most recently from e16f1b9 to 0f37a4c Compare October 27, 2022 07:19
@coot coot mentioned this pull request Nov 7, 2022
Merged
2 tasks
@coot
Copy link
Contributor Author

coot commented Nov 7, 2022

bors merge

@coot coot self-assigned this Nov 7, 2022
@coot coot added networking io-sim Issues related to io-sim and io-sim-classes. labels Nov 7, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 7, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit b9f91e6 into master Nov 7, 2022
@iohk-bors iohk-bors bot deleted the coot/io-sim branch November 7, 2022 16:39
@michaelpj michaelpj mentioned this pull request Nov 7, 2022
Merged
iohk-bors bot added a commit that referenced this pull request Nov 9, 2022
@iohk-bors @mtullsen @coot
Merge #4120
e933084 
4120: Cherry picked network changes for cardano-node-1.35.5 release r=coot a=coot

This cherry-picked patches from the following PRs:

* #3794
* #3844
* #3785
* #3904
* #3915
* #3852
* #3970
* #3979
* #4015
* #4067
* #4004
* #4086
* #4113
* #4106
* #4127
* #4103

Also cherry-picked almost all the commits which modify GitHub actions:
* 18c5244 Run GitHub Actions on pull requests   
* 3adf5a9 Use newer version of io-sim           
* ee9b7a6 Fix GH Actions Windows CI: switch from pkgconf to pkg-config 
* e6cf074 github-actions: use `ubuntu-latest`   
* 9a8b959 Updated versions of github actions    
* fc8f8f0 Fix GH Actions Windows CI caching     
* 7f07c40 Windows Github Actions now use MSYS2  
* b21a7ce Fix chocolatey CI error
* #4134               

TODO:

* [x] bump versions of packages
* [x] input-output-hk/cardano-haskell-packages#84

Co-authored-by: Mark Tullsen <[email protected]>
Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amesgen amesgen amesgen left review comments

@bolt12 bolt12 bolt12 approved these changes

@nfrisby nfrisby Awaiting requested review from nfrisby

@dnadales dnadales Awaiting requested review from dnadales

Assignees

@coot coot

Labels
io-sim Issues related to io-sim and io-sim-classes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coot @amesgen @bolt12