feat: remove more common unnecessary files (#513)

## PR Checklist

- [x] Addresses an existing open issue: fixes #452; fixes #512
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds some more globs to the list of those to remove.

Author: JoshuaKGoldberg

cspell.json

@@ -19,11 +19,12 @@
 		"knip",
 		"lcov",
 		"markdownlintignore",
+		"npmignore",
 		"npmpackagejsonlintrc",
 		"outro",
 		"packagejson",
-		"Unstaged",
 		"quickstart",
+		"Unstaged",
 		"wontfix"
 	]
 }

src/hydrate/steps/clearUnnecessaryFiles.test.ts

@@ -11,9 +11,11 @@ vi.mock("execa", () => ({
 }));
 
 describe("clearUnnecessaryFiles", () => {
-	it("runs all commands even when they fail", async () => {
+	it("removes all globs, quoted", async () => {
 		await clearUnnecessaryFiles();
 
-		expect(mockExecaCommand).toHaveBeenCalledWith(`rm -rf ./src/**/*.js`);
+		expect(mockExecaCommand).toHaveBeenCalledWith(
+			`rm -rf "./src/**/*.js" ".eslintrc.j*" ".npmignore" ".prettierrc.*" "babel.*" "CODE_OF_CONDUCT.md" "CONTRIBUTING.md" "DEVELOPMENT.md" "dist" "jest.*" "lib" "package-lock.json" "yarn.lock"`
+		);
 	});
 });

src/hydrate/steps/clearUnnecessaryFiles.ts

@@ -1,15 +1,27 @@
 import { execaCommand } from "execa";
 
+const ignoreGlobs = [
+	"./src/**/*.js",
+	".eslintrc.j*",
+	".npmignore",
+	".prettierrc.*",
+	"babel.*",
+	"CODE_OF_CONDUCT.md",
+	"CONTRIBUTING.md",
+	"DEVELOPMENT.md",
+	"dist",
+	"jest.*",
+	"lib",
+	"package-lock.json",
+	"yarn.lock",
+];
+
 export async function clearUnnecessaryFiles() {
-	for (const glob of [
-		"dist lib package-lock.json yarn.lock",
-		".eslintrc*",
-		"./src/**/*.js",
-	]) {
-		try {
-			await execaCommand(`rm -rf ${glob}`);
-		} catch {
-			// (we ignore failures if nothing matched)
-		}
+	try {
+		await execaCommand(
+			`rm -rf ${ignoreGlobs.map((glob) => `"${glob}"`).join(" ")}`
+		);
+	} catch {
+		// (we ignore failures if nothing matched)
 	}
 }