🚀 Feature: Hydration script should run ESLint autofixer #452
Assignees
Labels
status: accepting prs
Please, send a pull request to resolve this!
type: feature
New enhancement or request
Comments
JoshuaKGoldberg
added
type: feature
3 tasks
JoshuaKGoldberg
added a commit
that referenced
this issue
Jun 6, 2023
## PR Checklist - [x] Addresses an existing open issue: fixes #452; fixes #512 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Adds some more globs to the list of those to remove.
|
🎉 This is included in version v1.28.7 🎉 The release is available on: Cheers! 📦🚀 |
1 similar comment
|
🎉 This is included in version v1.28.7 🎉 The release is available on: Cheers! 📦🚀 |
3 tasks
JoshuaKGoldberg
added a commit
that referenced
this issue
Jun 7, 2023
## PR Checklist - [x] Addresses an existing open issue: fixes #452 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Per the issue, runs `pnpm lint --fix` near the end of hydration. Also runs `pnpm format --write`. For both, if there was an error, the user is warned to run the command themselves. Rewords from _"Succeeded"_ to _"Passed"_ for spinner blocks to indicate that there might not have been a total success.
|
🎉 This is included in version v1.28.8 🎉 The release is available on: Cheers! 📦🚀 |
1 similar comment
|
🎉 This is included in version v1.28.8 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report Checklist
mainbranch of the repository.Overview
#441 added a hydration script that updates an existing repository to use this template's goodness. But the existing repository may have some lint failures at the end of the script, such as using extension-less imports (
... from "./file"instead of... from "./file.js").Let's have the hydration script run
pnpm run lint --fixafter it finishespnpm run format:write!Additional Info
No response
The text was updated successfully, but these errors were encountered: