Skip to content

Commit 597f186

Browse files
fix: update remaining actions/checkout versions from 3 to 4 (#831)
## PR Checklist - [x] Addresses an existing open issue: fixes #796 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Turns out it was failing over diffs like: ```plaintext diff --git a/.github/workflows/tsc.yml b/.github/workflows/tsc.yml index 3b20f24..0e11a07 100644 --- a/.github/workflows/tsc.yml +++ b/.github/workflows/tsc.yml @@ -2,7 +2,7 @@ jobs: type_check: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v3 - uses: ./.github/actions/prepare - run: pnpm tsc ``` You can see them by downloading the raw logs artifacts from the failing builds.
1 parent d3b4c85 commit 597f186

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

.github/workflows/lint-packages.yml

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ name: Lint Packages
1010

1111
on:
1212
pull_request: ~
13-
1413
push:
1514
branches:
1615
- main

src/steps/writing/creation/dotGitHub/createWorkflowFile.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe("createWorkflowFile", () => {
1414
test_name:
1515
runs-on: ubuntu-latest
1616
steps:
17-
- uses: actions/checkout@v3
17+
- uses: actions/checkout@v4
1818
- uses: ./.github/actions/prepare
1919
- run: pnpm build
2020

src/steps/writing/creation/dotGitHub/createWorkflowFile.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export function createWorkflowFile({
7878
steps:
7979
"runs" in options
8080
? [
81-
{ uses: "actions/checkout@v3" },
81+
{ uses: "actions/checkout@v4" },
8282
{ uses: "./.github/actions/prepare" },
8383
...options.runs.map((run) => ({ run })),
8484
]

src/steps/writing/creation/dotGitHub/workflows.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ export function createWorkflows(options: Options) {
7777
},
7878
},
7979
steps: [
80-
{ uses: "actions/checkout@v3", with: { "fetch-depth": 0 } },
80+
{ uses: "actions/checkout@v4", with: { "fetch-depth": 0 } },
8181
{ uses: "./.github/actions/prepare" },
8282
{
8383
env: { GITHUB_TOKEN: "${{ secrets.ACCESS_TOKEN }}" },
@@ -129,7 +129,7 @@ export function createWorkflows(options: Options) {
129129
},
130130
},
131131
steps: [
132-
{ uses: "actions/checkout@v3", with: { "fetch-depth": 0 } },
132+
{ uses: "actions/checkout@v4", with: { "fetch-depth": 0 } },
133133
{
134134
run: `echo "npm_version=$(npm pkg get version | tr -d '"')" >> "$GITHUB_ENV"`,
135135
},
@@ -168,7 +168,7 @@ export function createWorkflows(options: Options) {
168168
},
169169
steps: [
170170
{
171-
uses: "actions/checkout@v3",
171+
uses: "actions/checkout@v4",
172172
with: {
173173
"fetch-depth": 0,
174174
},
@@ -268,7 +268,7 @@ export function createWorkflows(options: Options) {
268268
"test.yml": createWorkflowFile({
269269
name: "Test",
270270
steps: [
271-
{ uses: "actions/checkout@v3" },
271+
{ uses: "actions/checkout@v4" },
272272
{ uses: "./.github/actions/prepare" },
273273
{ run: "pnpm run test --coverage" },
274274
{

0 commit comments

Comments
 (0)