Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Tooling: Migration end-to-end tests are failing on main #796

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 5, 2023 · 2 comments · Fixed by #831
Closed
3 tasks done

🛠 Tooling: Migration end-to-end tests are failing on main #796

JoshuaKGoldberg opened this issue Sep 5, 2023 · 2 comments · Fixed by #831
Assignees
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

I pushed things directly to the main branch and this is my punishment.

https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/6085593506/job/16510050783:

Run pnpm run migrate:test
  pnpm run migrate:test
  shell: /usr/bin/bash -e {0}
  env:
    PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin

> create-typescript-app@1.[2](https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/6085593506/job/16510050783#step:5:2)9.[3](https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/6085593506/job/16510050783#step:5:3)2 migrate:test /home/runner/work/create-typescript-app/create-typescript-app
> node script/migrate-test-e2e.js

(node:191[4](https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/6085593506/job/16510050783#step:5:4)) ExperimentalWarning: Import assertions are not a stable feature of the JavaScript language. Avoid relying on their current behavior and syntax as those might change in a future version of Node.js.
(Use `node --trace-warnings ...` to show where the warning was created)
(node:1914) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
┌  Welcome to create-typescript-app ! 🎉
│
│  ⚠️ This template is early stage, opinionated, and not endorsed by the TypeScript team. ⚠️
│  ⚠️ If any tooling it sets displeases you, you can always remove that portion manually. ⚠️
│
◇  Migrating repository structure...
│   - Clearing unnecessary files.│   - Clearing unnecessary files ✔️
│   - Writing structure.│   - Writing structure..│   - Writing structure ✔️
│   - Writing README.md.│   - Writing README.md ✔️
│   - Updating local files.│   - Updating local files ✔️
│   - Updating all-contributors table.│   - Updating all-contributors table..│   - Updating all-contributors table│   - Updating all-contributors table..│   - Updating all-contributors table│   - Updating all-contributors table..│   - Updating all-contributors table│   - Updating all-contributors table..│   - Updating all-contributors table│   - Updating all-contributors table..│   - Updating all-contributors table│   - Updating all-contributors table..│   - Updating all-contributors table│   - Updating all-contributors table..│   - Updating all-contributors table│   - Updating all-contributors table..│   - Updating all-contributors table│   - Updating all-contributors table..│   - Updating all-contributors table ✔️
│
◇  ✅ Passed migrating repository structure.
2[5](https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/6085593506/job/16510050783#step:5:5)l│

...what's the failure?!

Additional Info

No response

@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Sep 5, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 18, 2023
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Sep 18, 2023
@JoshuaKGoldberg
Copy link
Owner Author

JoshuaKGoldberg commented Sep 18, 2023

Well, the CLI output in GHA seems to be timing out, but:

Oh no! Running the migrate script modified some files:
 - .github/workflows/build.yml
 - .github/workflows/lint-markdown.yml
 - .github/workflows/lint-package-json.yml
 - .github/workflows/lint-packages.yml
 - .github/workflows/lint-spelling.yml
 - .github/workflows/post-release.yml
 - .github/workflows/prettier.yml
 - .github/workflows/tsc.yml

That likely indicates changes made to the repository without
corresponding updates to templates in src/.

Please search for those file(s)' name(s) under src/migrate for
the corresponding template and update those as well.
 ELIFECYCLE  Command failed with exit code 1.
joshgoldberg ~/repos/create-typescript-app $ 

Ah, you can see the failures by downloading the full build logs. I'll make a note in the docs.

JoshuaKGoldberg added a commit that referenced this issue Sep 18, 2023
## PR Checklist

- [x] Addresses an existing open issue: fixes #796
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Turns out it was failing over diffs like:

```plaintext
diff --git a/.github/workflows/tsc.yml b/.github/workflows/tsc.yml
index 3b20f24..0e11a07 100644
--- a/.github/workflows/tsc.yml
+++ b/.github/workflows/tsc.yml
@@ -2,7 +2,7 @@ jobs:
   type_check:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v3
       - uses: ./.github/actions/prepare
       - run: pnpm tsc
```

You can see them by downloading the raw logs artifacts from the failing
builds.
@github-actions
Copy link

🎉 This is included in version v1.29.39 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant