Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update remaining actions/checkout versions from 3 to 4 #831

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Turns out it was failing over diffs like:

diff --git a/.github/workflows/tsc.yml b/.github/workflows/tsc.yml
index 3b20f24..0e11a07 100644
--- a/.github/workflows/tsc.yml
+++ b/.github/workflows/tsc.yml
@@ -2,7 +2,7 @@ jobs:
   type_check:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v3
       - uses: ./.github/actions/prepare
       - run: pnpm tsc

You can see them by downloading the raw logs artifacts from the failing builds.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #831 (acb1c0a) into main (d3b4c85) will not change coverage.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##             main     #831   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files          84       84           
  Lines        4161     4161           
  Branches      248      248           
=======================================
  Hits         3812     3812           
  Misses        349      349           
Flag Coverage Δ
create 72.04% <60.00%> (ø)
initialize 34.08% <0.00%> (ø)
migrate 73.35% <60.00%> (ø)
unit 47.70% <20.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/steps/writing/creation/dotGitHub/workflows.ts 88.33% <50.00%> (ø)
...s/writing/creation/dotGitHub/createWorkflowFile.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg merged commit 597f186 into main Sep 18, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the fix-migrate-artifacts branch September 18, 2023 13:58
@github-actions
Copy link

🎉 This is included in version v1.29.39 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Migration end-to-end tests are failing on main
1 participant