Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: package.json files array should include bin entry #1147

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 30, 2023 · 1 comment · Fixed by #1149
Closed
3 tasks done

🐛 Bug: package.json files array should include bin entry #1147

JoshuaKGoldberg opened this issue Dec 30, 2023 · 1 comment · Fixed by #1149
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Dec 30, 2023 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Running npx create-typescript-app --bin ./bin/index.js or similar should set up the package.json's files array to include the bin file.

Actual

#1146 is helping me see that, in fact, the file is excluded from publishing by default:

create-typescript-app/script/__snapshots__/migrate-test-e2e.js.snap

Lines 793 to 796 in 8d48fee

"bin": "./bin/index.js",
"files": [
- "bin/",
"lib/",

Additional Info

If a bin entry is provided, the template should include it in that array.
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Dec 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 30, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Dec 30, 2023
@JoshuaKGoldberg
fix: include bin entry in package.json files (#1149)
206c835 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1147
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Includes a `files` entry if `bin` exists. Also strips a preceding `./`
from it if it's there.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.51.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: include bin entry in package.json files JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg