chore: transform noisy files in e2e migration test #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1146 +/- ##
=======================================
Coverage 94.27% 94.27%
=======================================
Files 97 97
Lines 5627 5627
Branches 455 455
=======================================
Hits 5305 5305
Misses 321 321
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3 tasks
JoshuaKGoldberg
commented
Dec 30, 2023
| test.each([...filesExpectedToBeChanged])("verify %s", async (file) => { | ||
| const { stdout } = await execaCommand(`git diff HEAD -- ${file}`); | ||
| expect(stdout.split("\n").slice(2).join("\n")).toMatchSnapshot(); | ||
| // All Contributors seems to not be using Prettier to format files... |
There was a problem hiding this comment.
💡 I wonder if it's that this repo's prettier config has plugins that need to be installed!
|
🎉 This is included in version v1.50.2 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
In the migration script, after running with
--mode migratebut before running test assertions, modifies a couple of files on disk:.all-contributorsrc: Formats withJSON.stringify(..., null, 2)as it seems All Contributors isn't able to use Prettier for it.github/DEVELOPMENT.md: Adds back in the## The Setup Scriptsheading, as it's not part of the default templateAlso wraps the
tests indescribeand standardizes naming just a bit. I'm very nitpicky.