-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bug: Setup script crashes with 'Error writing structure' #1195
Comments
👋 thanks for filing @lcforbes! Good spot on the
Amusingly, that line of code has been there for several months without issue till now (typicode/husky#1177 -> #718 -> #719). Looks like this package isn't getting used on Windows at all. I suspect that fix might not be necessary on Windows at all. Just if you move to or start with a *nix system. I'll send a quick fix to wrap the command in a try/catch. Aside: I edited your post to wrap the pasted terminal output as a code block with |
## PR Checklist - [x] Addresses an existing open issue: fixes #1195 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Wraps the `chmod` with a `try`/`catch`. I figure if it fails then that's probably a sign the running OS doesn't have it and therefore doesn't need it.
@all-contributors please add @lcforbes for bug.
|
I've put up a pull request to add @lcforbes! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
🎉 This is included in version v1.52.7 🎉 The release is available on: Cheers! 📦🚀 |
Adds @lcforbes as a contributor for bug. This was requested by JoshuaKGoldberg [in this comment](#1195 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Bug Report Checklist
main
branch of the repository.Expected
You should be able to run 'npx create-typescript-app'.
Actual
Additional Info
I am running on Windows 11, yet I see that the script is attempting to run the Unix 'chmod' command.
The text was updated successfully, but these errors were encountered: