Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow chmod to fail in setup #1197

Merged
merged 1 commit into from
Jan 6, 2024
Merged

fix: allow chmod to fail in setup #1197

merged 1 commit into from
Jan 6, 2024

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Wraps the chmod with a try/catch. I figure if it fails then that's probably a sign the running OS doesn't have it and therefore doesn't need it.

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff5f7fd) 94.68% compared to head (4ecd099) 94.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1197   +/-   ##
=======================================
  Coverage   94.68%   94.69%           
=======================================
  Files         102      102           
  Lines        5685     5689    +4     
  Branches      466      468    +2     
=======================================
+ Hits         5383     5387    +4     
  Misses        301      301           
  Partials        1        1           
Flag Coverage Δ
create 70.26% <50.00%> (-0.04%) ⬇️
initialize 42.47% <0.00%> (-0.04%) ⬇️
migrate 69.82% <50.00%> (-0.04%) ⬇️
unit 73.82% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg
Copy link
Owner Author

Test failures are unrelated: #877.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 4568cb9 into main Jan 6, 2024
@JoshuaKGoldberg JoshuaKGoldberg deleted the chmod-try-catch branch January 6, 2024 14:33
Copy link

github-actions bot commented Jan 6, 2024

🎉 This is included in version v1.52.7 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Setup script crashes with 'Error writing structure'
1 participant