🛠 Tooling: Are actions/upload-artifact calls necessary in test*.yml?

[JoshuaKGoldberg]

Bug Report Checklist

• I have tried restarting my IDE and the issue persists.
• I have pulled the latest main branch of the repository.
• I have searched for related issues and found none that matched my issue.

Overview

Right now, the end-to-end migration test snapshot shows that this repo includes actions/upload-artifact in its test.yml despite the template not including that call:

create-typescript-app/script/__snapshots__/migrate-test-e2e.js.snap

Lines 53 to 71 in c4025fa

	exports[`expected file changes > .github/workflows/test.yml 1`] = `
	"--- a/.github/workflows/test.yml
	+++ b/.github/workflows/test.yml
	@@ ... @@ jobs:
	- run: pnpm run test --coverage
	- name: Codecov
	uses: codecov/codecov-action@v3
	- with:
	- flags: unit
	- - if: always()
	- name: Archive code coverage results
	- uses: actions/upload-artifact@v4
	- with:
	- name: code-coverage-report
	- path: coverage
	name: Test
	"
	`;

I don't think that uploading is necessary. Let's delete the lines in .github/workflows/test*.yml.

Additional Info

This repo has had a few Codecov changes in the past:

• chore: add test coverage testing with Codecov #79 originally added test.yml codecov uploading
• 🛠 Tooling: Add instrumentation to repo end-to-end tests #472 -> build: also track e2e test coverage #473 added coverage tracking for end-to-end tests
• 🛠 Tooling: Use codecov flags #544 -> feat: add codecov-action flags #545 used Codecov flags to prevent comments from incorrectly mentioning in-progress coverage percentages
• 🛠 Tooling: Codecov is commenting before all 3 builds are done #564 -> build: add codecov.yml #565 added a codecov.yml so that coverage from the four tests (3 x end-to-end, 1 x unit) get merged together before any notifications are sent

#473 is what mentions the code coverage reports:

For convenience, all coverage reports are stored in GitHub Actions (https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts).

I've never used that convenience. And codecov also has an online viewer.

[github-actions]

🎉 This is included in version v1.54.0 🎉

The release is available on:

• GitHub releases
• npm package (@latest dist-tag)

Cheers! 📦🚀