Skip to content

build: also track e2e test coverage #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 22, 2023
Merged

build: also track e2e test coverage #473

merged 12 commits into from
May 22, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented May 22, 2023

PR Checklist

Overview

Again uses the codecov/codecov-action to store coverage reports, this time from coverage-hydrate and coverage-setup.

For convenience, all coverage reports are stored in GitHub Actions (https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts).

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #473 (d26adf4) into main (4f13558) will increase coverage by 58.05%.
The diff coverage is 6.15%.

@@             Coverage Diff             @@
##             main     #473       +/-   ##
===========================================
+ Coverage   30.79%   88.84%   +58.05%     
===========================================
  Files          44       45        +1     
  Lines         328     2044     +1716     
  Branches       68       94       +26     
===========================================
+ Hits          101     1816     +1715     
- Misses        204      226       +22     
+ Partials       23        2       -21     
Impacted Files Coverage Δ
src/setup/index.ts 0.00% <0.00%> (ø)
src/setup/setup.ts 0.00% <0.00%> (ø)
src/setup/steps/uninstallPackages.ts 0.00% <0.00%> (ø)
src/setup/steps/updateLocalFiles.ts 0.00% <ø> (ø)
src/hydrate/creation/rootFiles.ts 99.74% <100.00%> (+66.40%) ⬆️
src/hydrate/finalize.ts 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review May 22, 2023 15:10
@@ -1,6 +1,10 @@
import chalk from "chalk";
import { $ } from "execa";

await $({
stdio: "inherit",
})`c8 -o ./coverage-hydrate -r html -r lcov node ./lib/hydrate/index.js`;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This, ah, should have been added already...

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🎉 This is included in version v1.28.1 🎉

The release is available on:

Cheers! 📦🚀

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🎉 This is included in version v1.28.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Add instrumentation to repo end-to-end tests
1 participant