Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Re-run command doesn't include --base #1276

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 23, 2024 · 1 comment · Fixed by #1301
Closed
3 tasks done

🐛 Bug: Re-run command doesn't include --base #1276

JoshuaKGoldberg opened this issue Jan 23, 2024 · 1 comment · Fixed by #1301
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

When you run npx create-typescript-app, select a base, and then quit out, the re-run command it suggests should include that --base.

Actual

From filling in an everything base manually and providing all other information, the suggested re-run command doesn't include --base:

npx create-typescript-app --mode create --access public --description "Fetches any packages associated with an npm username. 📨" --directory npm-username-to-packages --email-github [email protected] --email-npm [email protected] --mode create --owner JoshuaKGoldberg --repository npm-username-to-packages --title npm-username-to-packages

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Jan 23, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Feb 13, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Feb 13, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Feb 14, 2024
@JoshuaKGoldberg
fix: include base in rerun commands (#1301)
2dfb7b5 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1276
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Attaches `base` the options returned during augmentation, so they can
get printed out later.

I noticed that the `exclusionKeys` stuff was exported from the
`augmentOptionsWithExcludes.ts` file but never used in its tests. So I
extracted it to a new `exclusionKeys.ts`.

Adds some unit tests, but doesn't do all of #699. There's still coverage
missing.

Co-authored-by: @niklas-wortmann
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.57.3 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: include base in rerun commands JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg