fix: include base in rerun commands #1301
Merged
+220
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! :D |
|
@all-contributors please add @niklas-wortmann for code.
|
|
I've put up a pull request to add @niklas-wortmann! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
|
🎉 This is included in version v1.57.3 🎉 The release is available on: Cheers! 📦🚀 |
JoshuaKGoldberg
pushed a commit
that referenced
this pull request
Feb 14, 2024
Adds @niklas-wortmann as a contributor for code. This was requested by JoshuaKGoldberg [in this comment](#1301 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Attaches
basethe options returned during augmentation, so they can get printed out later.I noticed that the
exclusionKeysstuff was exported from theaugmentOptionsWithExcludes.tsfile but never used in its tests. So I extracted it to a newexclusionKeys.ts.Adds some unit tests, but doesn't do all of #699. There's still coverage missing.
Co-authored-by: @niklas-wortmann