Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Generated legacy ESLint config should use plugin:markdown/recommended-legacy #1380

Closed
3 tasks done
JoshuaKGoldberg opened this issue Mar 14, 2024 · 1 comment · Fixed by #1381
Closed
3 tasks done

🐛 Bug: Generated legacy ESLint config should use plugin:markdown/recommended-legacy #1380

JoshuaKGoldberg opened this issue Mar 14, 2024 · 1 comment · Fixed by #1381
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Creating a new repo with this template and running pnpm lint should pass.

Actual

Instead, we get this lovely bit:


Oops! Something went wrong! :(

ESLint: 8.57.0

TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'Array'
    |     index 0 -> object with constructor 'Object'
    |     property 'plugins' -> object with constructor 'Object'
    |     ...
    |     property 'configs' -> object with constructor 'Object'
    --- property 'recommended' closes the circle
Referenced from: /Users/josh/repos/my-example-repo/.eslintrc.cjs

Additional Info

The offending bit is this line:

create-typescript-app/.eslintrc.cjs

Line 28 in d7b43c3

extends: ["plugin:markdown/recommended"],

It's plugin:markdown/recommended-legacy now.
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Mar 14, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Mar 14, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 14, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Mar 14, 2024
@JoshuaKGoldberg
fix: use plugin:markdown/recommended-legacy (#1381)
b607c44 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1380
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Switches to the `recommended-legacy` plugin and bumps
`eslint-plugin-markdown` to the latest version, 4.x.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.57.9 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use plugin:markdown/recommended-legacy JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg