-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor Base options to (mostly) properly use Bingo Inputs #1985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1985 +/- ##
==========================================
+ Coverage 99.11% 99.92% +0.81%
==========================================
Files 93 106 +13
Lines 4061 4187 +126
Branches 232 253 +21
==========================================
+ Hits 4025 4184 +159
+ Misses 36 3 -33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🎉 This is included in version v2.6.1 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
status: accepting prs
Overview
Migrates the existing options over when possible. A couple are based on external packages that aren't easy to stub out external dependencies for. Those can be followup issues.
Now,
base.ts
generally contains a more consistent pattern with naming:get*
arelazyValue(async () => await read*(...))
functions for each valueread*
are async functions that take in any number ofget*
s to compute a valueAlso removes an unused
logic
field while I'm here.This is a
fix:
because it adds better handling for running without a reliable internet connection:npm whoami --offline
to stop a minute of internal retriesrequest: { retries: 0 }
oninputFromOctkit
to stop its retries too🎁