Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: keywords are not inferred from existing package.json #2094

Closed
3 tasks done
JoshuaKGoldberg opened this issue Apr 2, 2025 · 1 comment · Fixed by #2105
Closed
3 tasks done

🐛 Bug: keywords are not inferred from existing package.json #2094

JoshuaKGoldberg opened this issue Apr 2, 2025 · 1 comment · Fixed by #2105
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Milestone
Transition Mode A...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Running npx create-typescript-app on a repo with keywords in its package.json file should not wipe those keywords.

Actual

https://github.com/JoshuaKGoldberg/package-json-validator/pull/178/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L11 shows that they are.

Additional Info

Keywords were originally added in #886.

🎁
@JoshuaKGoldberg JoshuaKGoldberg added the type: bug Something isn't working :( label Apr 2, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Apr 2, 2025
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label Apr 2, 2025
This was referenced Apr 2, 2025
Merged
Merged
JoshuaKGoldberg added a commit that referenced this issue Apr 2, 2025
@JoshuaKGoldberg
fix: read keywords from package.json during transition (#2105)
a1304c2 
## PR Checklist

- [x] Addresses an existing open issue: fixes #2094
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Removes the removal & flat-mapping from spaces because keywords actually
can have spaces in them. CLI folks will have to specify them
individually.

🎁
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2025

🎉 This is included in version v2.22.8 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
Transition Mode Automation
Development

Successfully merging a pull request may close this issue.

fix: read keywords from package.json during transition JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg