Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support package.json keywords #886

Merged
merged 7 commits into from
Sep 29, 2023
Merged

feat: support package.json keywords #886

merged 7 commits into from
Sep 29, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Adds keywords as an allowed arg. I set it to plural instead of the singular keyword because I expect I'll be specifying many, multiple, keywords.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #886 (b04641d) into main (715e79d) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 95.83%.

@@           Coverage Diff           @@
##             main     #886   +/-   ##
=======================================
  Coverage   93.56%   93.57%           
=======================================
  Files          89       89           
  Lines        4711     4729   +18     
  Branches      373      378    +5     
=======================================
+ Hits         4408     4425   +17     
- Misses        302      303    +1     
  Partials        1        1           
Flag Coverage Δ
create 71.96% <78.26%> (-0.01%) ⬇️
initialize 37.17% <73.91%> (+0.12%) ⬆️
migrate 70.75% <78.26%> (-0.01%) ⬇️
unit 67.25% <95.83%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/create/createRerunSuggestion.ts 100.00% <100.00%> (ø)
src/shared/options/args.ts 100.00% <100.00%> (ø)
src/shared/options/optionsSchema.ts 100.00% <100.00%> (ø)
src/steps/writing/creation/writePackageJson.ts 100.00% <100.00%> (ø)
src/shared/types.ts 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg merged commit 1399071 into main Sep 29, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the keywords branch September 29, 2023 15:21
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Prompt for keywords in package.json
1 participant