Skip to content

🚀 Feature: Fill in allcontributors contributions at end of hydration #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
JoshuaKGoldberg opened this issue May 20, 2023 · 1 comment · Fixed by #639
Closed
3 tasks done

🚀 Feature: Fill in allcontributors contributions at end of hydration #448

JoshuaKGoldberg opened this issue May 20, 2023 · 1 comment · Fixed by #639
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented May 20, 2023 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

#441 added a hydration script that can set up an existing repository with this template's tooling. But it doesn't do anything special for the .all-contributorsrc file. That file is just a copy & paste of a basic template.

It'd be nice if the script ran all-contributors-for-repository to fill in the .all-contributorsrc after the file template is applied. That repo's readme has a suggested little blurb you can do:

import { $ } from "execa";

for (const [contributor, contributions] of Object.entries(contributors)) {
	const contributionTypes = Object.keys(contributions).join(",");
	await $`npx all-contributors add ${contributor} ${contributionTypes}`;
}

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels May 20, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 7, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Aug 7, 2023
@JoshuaKGoldberg
feat: fill in existing contributors in hydration (#639)
e7fc398 
## PR Checklist

- [x] Addresses an existing open issue: fixes #448
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds detecting existing contributors with
[`all-contributors-for-repository`](https://github.com/JoshuaKGoldberg/all-contributors-for-repository),
along with a `--skip-contributors` flag to skip that.
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This is included in version v1.28.48 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: fill in existing contributors in hydration JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg