🛠 Tooling: Add more unit testing around src/setup #471
Labels
area: testing
Improving how the repository's tests are run and/or code is tested
good first issue
Good for newcomers, please hop on!
status: accepting prs
Please, send a pull request to resolve this!
Comments
JoshuaKGoldberg
added
good first issue
This was referenced May 22, 2023
3 tasks
JoshuaKGoldberg
added a commit
that referenced
this issue
Jun 14, 2023
## PR Checklist - [x] Addresses an existing open issue: makes progress on #471 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Adds a trio of test files. Doesn't exhaustively increase coverage (I want to leave that open to future contributors!), but hopefully gets us to a nicer green coverage badge in the README.md
3 tasks
JoshuaKGoldberg
added a commit
that referenced
this issue
Aug 22, 2023
## PR Checklist - [x] Addresses an existing open issue: fixes #471 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Gets through the rest of the relatively straightforward unit tests. At this point I think we can consider #471 to be resolved. Unit test coverage is >89%.
|
🎉 This is included in version v1.29.1 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report Checklist
mainbranch of the repository.Overview
#469 added a bunch of code under
src/setup/. But it didn't completely unit test everything! Shame on me. 😄I'm filing this tracking issue for adding more unit test coverage to files in that folder. Accepting PRs that add any amount of tests - you don't have to unit test everything. In fact, I'd recommend starting with simpler functions first.
Additional Info
Tip: for the more complex functions, see how other more-complex functions are tested.
It may not be worth unit testing
src/setup/index.tsitself or the other more complex functions. 100% unit test coverage can be an annoying metric to go for.This is a sibling issue to #447.
The text was updated successfully, but these errors were encountered: