Skip to content

test: added a few new test files #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 14, 2023
Merged

test: added a few new test files #536

merged 5 commits into from
Jun 14, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Jun 14, 2023

PR Checklist

Overview

Adds a trio of test files. Doesn't exhaustively increase coverage (I want to leave that open to future contributors!), but hopefully gets us to a nicer green coverage badge in the README.md

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #536 (d87a09e) into main (9d626e6) will increase coverage by 0.27%.
The diff coverage is 100.00%.

❗ Current head d87a09e differs from pull request most recent head 3010582. Consider uploading reports for the commit 3010582 to get more accurate results

@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
+ Coverage   87.09%   87.36%   +0.27%     
==========================================
  Files          55       55              
  Lines        2936     2936              
  Branches      120      120              
==========================================
+ Hits         2557     2565       +8     
+ Misses        376      368       -8     
  Partials        3        3              
Impacted Files Coverage Δ
src/shared/getDefaultSettings.ts 61.53% <ø> (ø)
src/shared/inputs.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg changed the title test: added a couple new test files test: added a few new test files Jun 14, 2023
@JoshuaKGoldberg JoshuaKGoldberg merged commit 21f7303 into main Jun 14, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the a-few-tests branch June 14, 2023 20:23
@github-actions
Copy link

🎉 This is included in version v1.28.19 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant