-
-
Notifications
You must be signed in to change notification settings - Fork 80
test: added a few new test files #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Codecov Report
@@ Coverage Diff @@
## main #536 +/- ##
==========================================
+ Coverage 87.09% 87.36% +0.27%
==========================================
Files 55 55
Lines 2936 2936
Branches 120 120
==========================================
+ Hits 2557 2565 +8
+ Misses 376 368 -8
Partials 3 3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
🎉 This is included in version v1.28.19 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
status: accepting prs
Overview
Adds a trio of test files. Doesn't exhaustively increase coverage (I want to leave that open to future contributors!), but hopefully gets us to a nicer green coverage badge in the README.md