Skip to content

🐛 Bug: Setup script should remove hydrate entries from package.json #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
JoshuaKGoldberg opened this issue May 23, 2023 · 1 comment · Fixed by #571
Closed
3 tasks done

🐛 Bug: Setup script should remove hydrate entries from package.json #480

JoshuaKGoldberg opened this issue May 23, 2023 · 1 comment · Fixed by #571
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

The setup script (pnpm run setup) included in this template repository should remove all cruft from hydration & setup scripts. Things like pnpm run hydrate:test, pnpm run setup:test, etc.

Actual

I can see that I'd missed a couple of these in #441:

Whoopsies! Accepting PRs to add removals of those package.json lines to the setup script.

Additional Info

The setup script is located in src/setup. See https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/59b638031188fe26185e291403c8dd890ea692a1/src/setup/steps/updateLocalFiles.ts for the big list of replacements that should occur.

The setup script is documented at https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/73a08bfb0b1329660c402f3d10738e54257737a3/README.md#L46 for user-facing information and https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/d95fdf1e7dc9cd0646d28ae6095c1e463a8d6d11/.github/DEVELOPMENT.md#L95 for developer-facing information.
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels May 23, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jun 18, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jun 18, 2023
@JoshuaKGoldberg
fix: remove hydrate entries from package.json in setup (#571)
ddf66f0 
## PR Checklist

- [x] Addresses an existing open issue: fixes #480
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds a couple of removals and clumps them together.
@github-actions
Copy link

🎉 This is included in version v1.28.36 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove hydrate entries from package.json in setup JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg