Skip to content

🛠 Tooling: Setup end-to-end test should also factor into code coverage #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
JoshuaKGoldberg opened this issue Jun 1, 2023 · 4 comments · Fixed by #496
Closed
3 tasks done

🛠 Tooling: Setup end-to-end test should also factor into code coverage #495

JoshuaKGoldberg opened this issue Jun 1, 2023 · 4 comments · Fixed by #496
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

In #472 -> #473, I added code coverage tracking to the hydration end-to-end tests. It's merged with unit test code coverage.

However, I didn't add the tracking for setup end-to-end tests. Which is unfortunate because setup files are being counted as not having code coverage. Let's fix that!

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Jun 1, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jun 1, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jun 1, 2023
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg removed their assignment Jun 2, 2023
@JoshuaKGoldberg
Copy link
Owner Author

I tried this out in #496 and ran into issues. Leaving this open for anybody who wants to try it out.

From the upload on Codecov:

We recommend checking the Codecov step of this commit's CI Run to make sure it uploaded properly and, if needed, run your CI again.

Screenshot of Codecov saying 'unusable report' for a coverage file

It looks like the coverage-setup/lcov.info file doesn't include any actual coverage information:

I wonder if the issue is that the setup script deletes the src/shared & src/setup files that are being tracked?

JoshuaKGoldberg added a commit that referenced this issue Jun 2, 2023
@JoshuaKGoldberg
build: add coverage tracking to setup script (#496)
18ef648 
## PR Checklist

- [x] Addresses an existing open issue: fixes #495
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Uses similar tracking to the hydration script.
@JoshuaKGoldberg
Copy link
Owner Author

Solution from #496: run the setup script a second time, skipping the removal of files 😄

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🎉 This is included in version v1.28.1 🎉

The release is available on:

Cheers! 📦🚀

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🎉 This is included in version v1.28.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: add coverage tracking to setup script JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg