Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: If the user running initialize isn't already in allcontributors, add them #676

Closed
3 tasks done
JoshuaKGoldberg opened this issue Aug 22, 2023 · 1 comment · Fixed by #677
Closed
3 tasks done

🚀 Feature: If the user running initialize isn't already in allcontributors, add them #676

JoshuaKGoldberg opened this issue Aug 22, 2023 · 1 comment · Fixed by #677
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now, addOwnerAsContributor wipes out the .all-contributorsrc contributors except for "JoshuaKGoldberg" and the currently running user. But what if that user isn't yet in the contributors list? They should be added for "tool" if so.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Aug 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Aug 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 22, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Aug 22, 2023
@JoshuaKGoldberg
feat: ensure running user is included in .all-contributorsrc (#677)
556ea3a 
## PR Checklist

- [x] Addresses an existing open issue: fixes #676
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds some nice test coverage too.
@github-actions
Copy link

🎉 This is included in version v1.28.60 🎉

The release is available on:

Cheers! 📦🚀

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 6, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: ensure running user is included in .all-contributorsrc JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg