Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ensure running user is included in .all-contributorsrc #677

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 22, 2023

PR Checklist

Overview

Adds some nice test coverage too.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #677 (2e06af0) into main (71d4b96) will increase coverage by 3.32%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
+ Coverage   53.00%   56.32%   +3.32%     
==========================================
  Files          64       64              
  Lines         400      403       +3     
  Branches       77       77              
==========================================
+ Hits          212      227      +15     
+ Misses        177      165      -12     
  Partials       11       11              
Flag Coverage Δ
initialize ∅ <ø> (?)
migrate 100.00% <ø> (ø)
unit 55.88% <100.00%> (+3.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rc/initialize/settings/addOwnerAsAllContributor.ts 100.00% <100.00%> (+100.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg merged commit 556ea3a into main Aug 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the all-contributors-ensure-running-user branch August 22, 2023 04:39
@github-actions
Copy link

🎉 This is included in version v1.28.60 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: If the user running initialize isn't already in allcontributors, add them
1 participant