Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Also remove @vitest/coverage-istanbul in writePackageJson #759

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 2, 2023 · 1 comment · Fixed by #885
Closed
3 tasks done

🚀 Feature: Also remove @vitest/coverage-istanbul in writePackageJson #759

JoshuaKGoldberg opened this issue Sep 2, 2023 · 1 comment · Fixed by #885
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Milestone
Post-Rename Migra...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now, devDependenciesToRemove in writePackageJson.ts stores a list of packages that will be removed from package.json during setup:

create-typescript-app/src/steps/writing/creation/writePackageJson.ts

Lines 106 to 109 in c8bbfdb

for (const devDependencyToRemove of devDependenciesToRemove) {
// eslint-disable-next-line @typescript-eslint/no-dynamic-delete
delete devDependencies[devDependencyToRemove];
}

I'd previously used the Istanbul tool for code coverage, but switched over to v8 instead (#692 -> #693). So now the @vitest/coverage-istanbul tool is unused. It can be removed too.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Sep 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Post-Rename Migration milestone Sep 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Sep 22, 2023
@jaas666 jaas666 mentioned this issue Sep 24, 2023
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg removed their assignment Sep 24, 2023
JoshuaKGoldberg pushed a commit that referenced this issue Sep 24, 2023
@jaas666
feat: Add @vitest/coverage-istanbul to devDependenciesToRemove (#885)
36e236a 
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #759
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Added package `@vitest/coverage-istanbul` to devDependenciestoRemove as
requested in #759
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
Post-Rename Migration
Development

Successfully merging a pull request may close this issue.

feat: Add @vitest/coverage-istanbul to devDependenciesToRemove
1 participant
@JoshuaKGoldberg