Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add @vitest/coverage-istanbul to devDependenciesToRemove #885

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Conversation

jaas666
Copy link
Contributor

@jaas666 jaas666 commented Sep 24, 2023

PR Checklist

Overview

Added package @vitest/coverage-istanbul to devDependenciestoRemove as requested in #759

@jaas666 jaas666 changed the title Add @vitest/coverage-istanbul to devDependenciesToRemove feat: Add @vitest/coverage-istanbul to devDependenciesToRemove Sep 24, 2023
@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #885 (1f56860) into main (bfcd795) will decrease coverage by 0.01%.
Report is 7 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
- Coverage   92.77%   92.77%   -0.01%     
==========================================
  Files          89       89              
  Lines        4636     4675      +39     
  Branches      355      358       +3     
==========================================
+ Hits         4301     4337      +36     
- Misses        334      337       +3     
  Partials        1        1              
Flag Coverage Δ
create 70.84% <100.00%> (+0.14%) ⬆️
initialize 35.45% <100.00%> (-0.09%) ⬇️
migrate 70.16% <100.00%> (-0.03%) ⬇️
unit 60.00% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/steps/writing/creation/writePackageJson.ts 100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jaas666!

Just a heads up, I'd assigned myself the backing issue #759 because I'm meaning to chug through the remaining issues in https://github.com/JoshuaKGoldberg/create-typescript-app/milestone/2 this weekend (today). I'm planning on sending PRs over the next hour or two for the rest of them.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 36e236a into JoshuaKGoldberg:main Sep 24, 2023
@jaas666 jaas666 deleted the feat-759 branch September 24, 2023 23:46
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Also remove @vitest/coverage-istanbul in writePackageJson
2 participants