Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Replace parsePackageAuthor with npm package #789

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 4, 2023 · 1 comment · Fixed by #904
Closed
3 tasks done

🛠 Tooling: Replace parsePackageAuthor with npm package #789

JoshuaKGoldberg opened this issue Sep 4, 2023 · 1 comment · Fixed by #904
Labels
area: tooling Managing the repository's maintenance good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

This parsePackageAuthor function exists in the repository:

create-typescript-app/src/shared/options/readGitAndNpmDefaults/parsePackageAuthor.ts

Line 3 in a386c87

export function parsePackageAuthor(packageData: PartialPackageData) {

...but https://www.npmjs.com/package/parse-author already exists. There's no need for this repo to implement that logic when it could use an npm package.

Let's delete the parsePackageAuthor function (and its tests) from this repo, then use the parse-author package instead.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Sep 4, 2023
@kristo-baricevic kristo-baricevic mentioned this issue Sep 29, 2023
Merged
3 tasks
JoshuaKGoldberg pushed a commit that referenced this issue Oct 8, 2023
@kristo-baricevic
feat: replace parsePackageAuthor with npm package (#904)
d5d8d40 
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #789
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

#789 parse-author dependency was installed and the parse method was used
to replace split and trim logic on the string containing author's name
and email
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

🎉 This is included in version v1.37.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Managing the repository's maintenance good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: replace parsePackageAuthor with npm package
1 participant
@JoshuaKGoldberg