Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace parsePackageAuthor with npm package #904

Merged
merged 1 commit into from
Oct 8, 2023
Merged

feat: replace parsePackageAuthor with npm package #904

merged 1 commit into from
Oct 8, 2023

Conversation

kristo-baricevic
Copy link
Contributor

PR Checklist

Overview

#789 parse-author dependency was installed and the parse method was used to replace split and trim logic on the string containing author's name and email

@kristo-baricevic kristo-baricevic changed the title Tooling: 🛠 Replace parsePackageAuthor with npm package feat: replace parsePackageAuthor with npm package Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #904 (2173def) into main (2ea9d87) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #904   +/-   ##
=======================================
  Coverage   93.46%   93.47%           
=======================================
  Files          91       91           
  Lines        4852     4858    +6     
  Branches      405      403    -2     
=======================================
+ Hits         4535     4541    +6     
  Misses        316      316           
  Partials        1        1           
Flag Coverage Δ
create 71.13% <15.38%> (-0.05%) ⬇️
initialize 38.27% <69.23%> (+0.09%) ⬆️
migrate 69.98% <15.38%> (-0.05%) ⬇️
unit 68.12% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...options/createOptionDefaults/parsePackageAuthor.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kristo-baricevic
Copy link
Contributor Author

I was working through the checks git showed me, and after running pnpm lint the checks back been stuck on "expected - waiting for status to be reported"

Let me know how the titling and additional info looks! I enjoyed working on this feature.

@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Oct 1, 2023
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Oct 1, 2023
@JoshuaKGoldberg
Copy link
Owner

We chatted 1:1 a bit - the merge conflicts are stopping builds from running. And also looks like there are some other changes in the mix.

@kristo-baricevic
Copy link
Contributor Author

I am not exactly sure what happened there but I do know it happened when I was trying to respond to the red X's in git github checks, and it involved some installs and running npx create-typescript-app. So I backed up the HEAD of the branch to the commit before those changes were made.

@github-actions github-actions bot removed the status: waiting for author Needs an action taken by the original poster label Oct 8, 2023
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Clean implementation and passes all the existing tests. Nice.

Once you resolve the merge conflicts we should be good to go. 🚀

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 swell, thanks @kristo-baricevic!

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Oct 8, 2023

Initialization script failures are unrelated. Sorry for the noise :c

@JoshuaKGoldberg JoshuaKGoldberg merged commit d5d8d40 into JoshuaKGoldberg:main Oct 8, 2023
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

🎉 This is included in version v1.37.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Replace parsePackageAuthor with npm package
2 participants