-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace parsePackageAuthor with npm package #904
feat: replace parsePackageAuthor with npm package #904
Conversation
Codecov Report
@@ Coverage Diff @@
## main #904 +/- ##
=======================================
Coverage 93.46% 93.47%
=======================================
Files 91 91
Lines 4852 4858 +6
Branches 405 403 -2
=======================================
+ Hits 4535 4541 +6
Misses 316 316
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I was working through the checks git showed me, and after running pnpm lint the checks back been stuck on "expected - waiting for status to be reported" Let me know how the titling and additional info looks! I enjoyed working on this feature. |
We chatted 1:1 a bit - the merge conflicts are stopping builds from running. And also looks like there are some other changes in the mix. |
I am not exactly sure what happened there but I do know it happened when I was trying to respond to the red X's in git github checks, and it involved some installs and running npx create-typescript-app. So I backed up the HEAD of the branch to the commit before those changes were made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Clean implementation and passes all the existing tests. Nice.
Once you resolve the merge conflicts we should be good to go. 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 swell, thanks @kristo-baricevic!
Initialization script failures are unrelated. Sorry for the noise :c |
🎉 This is included in version v1.37.0 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
status: accepting prs
Overview
#789 parse-author dependency was installed and the parse method was used to replace split and trim logic on the string containing author's name and email