Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: some ESLint plugins not fully removed in 'common' template #864

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 21, 2023 · 1 comment · Fixed by #867
Closed
3 tasks done

🐛 Bug: some ESLint plugins not fully removed in 'common' template #864

JoshuaKGoldberg opened this issue Sep 21, 2023 · 1 comment · Fixed by #867
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Milestone
General Simplific...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Running pnpm lint in a repo made with --base common should work.

Actual

I'm seeing that eslint-plugin-jsonc and eslint-plugin-perfectionist are still referenced in the generated ESLint config. Whoops!

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Sep 21, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Sep 21, 2023
This was referenced Sep 21, 2023
Closed
Merged
JoshuaKGoldberg added a commit that referenced this issue Sep 21, 2023
@JoshuaKGoldberg
feat: much more ESLint config configurability (#867)
094b253 
## PR Checklist

- [x] Addresses an existing open issue: fixes #864; fixes #866
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds:

- `--exclude-lint-deprecation`
- `--exclude-lint-eslint`
- `--exclude-lint-jsdoc`
- `--exclude-lint-regex`
- `--exclude-lint-strict`
- `--exclude-lint-stylistic`

Assorted cleanups:

* Removes `eslint-config-prettier` since I believe none of the
recommended configs include rules impacted by it (yay!)
* Removes `eslint-plugin-import` as TypeScript's `"moduleResolution":
"NodeNext"` will report on a missing file extension in an import
* As of eslint-community/eslint-plugin-n#24 I
don't think `n/no-missing-import` is buggy enough to need to be disabled
* eslint-community/eslint-plugin-n#84 is still
in effect, but this template doesn't use `paths`.
* Removes the ESLint config comment now that most users are on a simpler
"common" config
* Finally add some high-level unit testing for `createESLintRC` to help
validate the changes
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
General Simplification
Development

Successfully merging a pull request may close this issue.

feat: much more ESLint config configurability JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg