Fix no-missing-import for typescript #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
reviewed
Jun 8, 2022
|
This is good to release as a patch or minor. |
3 tasks
JoshuaKGoldberg
added a commit
to JoshuaKGoldberg/create-typescript-app
that referenced
this pull request
Sep 21, 2023
## PR Checklist - [x] Addresses an existing open issue: fixes #864; fixes #866 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Adds: - `--exclude-lint-deprecation` - `--exclude-lint-eslint` - `--exclude-lint-jsdoc` - `--exclude-lint-regex` - `--exclude-lint-strict` - `--exclude-lint-stylistic` Assorted cleanups: * Removes `eslint-config-prettier` since I believe none of the recommended configs include rules impacted by it (yay!) * Removes `eslint-plugin-import` as TypeScript's `"moduleResolution": "NodeNext"` will report on a missing file extension in an import * As of eslint-community/eslint-plugin-n#24 I don't think `n/no-missing-import` is buggy enough to need to be disabled * eslint-community/eslint-plugin-n#84 is still in effect, but this template doesn't use `paths`. * Removes the ESLint config comment now that most users are on a simpler "common" config * Finally add some high-level unit testing for `createESLintRC` to help validate the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23
Refactored typescript logic into utilities for reuse.