Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧪 Testing: Fill in unit test coverage for createWithOptions.ts #874

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 22, 2023 · 1 comment · Fixed by #1183
Closed
3 tasks done

🧪 Testing: Fill in unit test coverage for createWithOptions.ts #874

JoshuaKGoldberg opened this issue Sep 22, 2023 · 1 comment · Fixed by #1183
Labels
area: testing Improving how the repository's tests are run and/or code is tested status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Splitting out of #869: the createWithOptions function is not currently unit tested. I'd love to see some unit tests added for it!

https://app.codecov.io/gh/JoshuaKGoldberg/create-typescript-app/blob/094b253411168038a2c7585e5172f8b773c18ea2/src%2Fcreate%2FcreateWithOptions.ts

Additional Info

It'll be a little verbose to set up, but a unit test file should be able to Vitest mock out all the functions being called (writeStructure, writeReadme, etc.). And it'll likely have to mock out withSpinners, too, to directly call each of the functions provided in order.
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! area: testing Improving how the repository's tests are run and/or code is tested labels Sep 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🛠 Tooling: Fill in unit test coverage for createWithOptions.ts 🧪 Tooling: Fill in unit test coverage for createWithOptions.ts Sep 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🧪 Tooling: Fill in unit test coverage for createWithOptions.ts 🧪 Testing: Fill in unit test coverage for createWithOptions.ts Sep 22, 2023
This was referenced Dec 28, 2023
Closed
Merged
JoshuaKGoldberg pushed a commit that referenced this issue Jan 3, 2024
@kristo-baricevic
chore: add updated test for createWithOptions.ts (#1183)
0b2d425 
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #874 
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

This is a test file for createWithOptions. It tests the logic of
createWithOptions..

This PR is an extension of a previous PR, #1119.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

🎉 This is included in version v1.52.7 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: testing Improving how the repository's tests are run and/or code is tested status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Milestone
No milestone
1 participant
@JoshuaKGoldberg