Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant format at end of finalizeDependencies #887

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

🔪.

Also fixes a lint --fix command I found that was running after formatting. Lint rule auto-fixers might introduce formatting issues, so they should be run first.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
JoshuaKGoldberg Josh Goldberg ✨
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #887 (25e6731) into main (36e236a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
- Coverage   92.77%   92.76%   -0.01%     
==========================================
  Files          89       89              
  Lines        4675     4673       -2     
  Branches      358      358              
==========================================
- Hits         4337     4335       -2     
  Misses        337      337              
  Partials        1        1              
Flag Coverage Δ
create 70.83% <100.00%> (-0.02%) ⬇️
initialize 35.46% <0.00%> (+0.01%) ⬆️
migrate 70.19% <0.00%> (+0.03%) ⬆️
unit 59.99% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/steps/finalizeDependencies.ts 100.00% <ø> (ø)
src/create/createWithOptions.ts 69.11% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg merged commit 973140d into main Sep 25, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the remove-redundant-format-write branch September 25, 2023 11:23
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Redundant format:write at the end of finalizeDependencies
1 participant