Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Post-creation/initialization messages can reference skipped features #903

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 29, 2023 · 1 comment · Fixed by #906
Closed
3 tasks done

🐛 Bug: Post-creation/initialization messages can reference skipped features #903

JoshuaKGoldberg opened this issue Sep 29, 2023 · 1 comment · Fixed by #906
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Milestone
Post-Rename Migra...

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Sep 29, 2023 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Users can pass in --exclude-releases and/or --exclude-tests. If they do, then the message shown after they finish running the script shouldn't mention setting up their tokens.

Actual

The scripts always do...

https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/b465f787923437929ebb2b1ce4474b8f0d2ee122/src/create/index.ts#L43

https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/b465f787923437929ebb2b1ce4474b8f0d2ee122/src/initialize/index.ts#L37

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Sep 29, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Post-Rename Migration milestone Sep 29, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Sep 29, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 30, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Sep 30, 2023
@JoshuaKGoldberg
fix: base suggested next steps on options (#906)
ddf1318 
## PR Checklist

- [x] Addresses an existing open issue: fixes #903
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Pulls the logging of next steps (app(s) and/or token(s) to enable) into
a dedicated `generateNextSteps` function, with unit tests. `outro` now
allows a `variant` for each group, as this new logging isn't the
preivously-always-gray code-style logging.
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
Post-Rename Migration
Development

Successfully merging a pull request may close this issue.

fix: base suggested next steps on options JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg