fix: base suggested next steps on options #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
commented
Sep 30, 2023
| "@typescript-eslint/prefer-nullish-coalescing": [ | ||
| "error", | ||
| { ignorePrimitives: true }, | ||
| ], |
There was a problem hiding this comment.
So that I can use booleanValue || somethingMoreComplex in the new function.
JoshuaKGoldberg
commented
Sep 30, 2023
| for (const excludeRenovate of [false, true]) { | ||
| for (const excludeTests of [false, true]) { | ||
| test( | ||
| // eslint-disable-next-line vitest/valid-title |
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## main #906 +/- ##
==========================================
+ Coverage 93.57% 93.77% +0.19%
==========================================
Files 89 90 +1
Lines 4731 4800 +69
Branches 378 394 +16
==========================================
+ Hits 4427 4501 +74
+ Misses 303 298 -5
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
🎉 This is included in version v1.32.0 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Pulls the logging of next steps (app(s) and/or token(s) to enable) into a dedicated
generateNextStepsfunction, with unit tests.outronow allows avariantfor each group, as this new logging isn't the preivously-always-gray code-style logging.