Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Migrating an existing package.json shouldn't remove "bin/" entry from "files" #934

Closed
3 tasks done
JoshuaKGoldberg opened this issue Oct 2, 2023 · 2 comments · Fixed by #1612
Closed
3 tasks done

🐛 Bug: Migrating an existing package.json shouldn't remove "bin/" entry from "files" #934

JoshuaKGoldberg opened this issue Oct 2, 2023 · 2 comments · Fixed by #1612
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Running npx create-typescript-app --mode migrate (with any base) on an existing repository shouldn't wipe out files entries if they correspond to files that should exist in the package.

Actual

Running npx create-typescript-app --mode migrate (with any base) on an existing repository right now overrides the repository's files entry (among others). But if the repository has file(s) under bin/, that means the new files entry won't include them anymore. Not good.

	"files": [
-		"bin/",
		"lib/",
		"package.json",
		"LICENSE.md",
		"README.md"
	],

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Oct 2, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 3, 2023
Closed
3 tasks
@JoshuaKGoldberg
Copy link
Owner Author

#938 is a superset of this issue, but is a bit more work. If that feature request is implemented first then we can close this issue. Otherwise I'd be accepting of a bugfix for this issue first.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 11, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Aug 11, 2024
@JoshuaKGoldberg
fix: correct remaining --auto mismatches (#1612)
551737a 
## PR Checklist

- [x] Addresses an existing open issue: fixes #934; fixes #1157; fixes
#1613
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Fills in a lot of logic around defaults that was previously not hooked
up. `--auto` now completely works as expected in this repository.

💖
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.67.3 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correct remaining --auto mismatches JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg