🚀 Feature: Enable no-useless-rename

[JoshuaKGoldberg]

Bug Report Checklist

• I have tried restarting my IDE and the issue persists.
• I have pulled the latest main branch of the repository.
• I have searched for related issues and found none that matched my issue.

Overview

Once in a while I find a piece of code that unnecessarily renames a destructured variable:

create-typescript-app/src/shared/options/ensureRepositoryExists.ts

Line 67 in ef2e348

return { github: github, repository };

That : github part is unnecessary. The code is essentially the same as:

- return { github: github, repository };
+ return { github, repository };

https://eslint.org/docs/latest/rules/no-useless-rename exists but isn't enabled yet. Let's add it in!

Additional Info

Note that there are multiple places you'll want to add no-useless-rename:

1. The repo's ESLint config:

   create-typescript-app/.eslintrc.cjs

   Line 162 in ddf1318

   // Stylistic concerns that don't interfere with Prettier

2. The template for generating repo ESLint configs:

   create-typescript-app/src/steps/writing/creation/createESLintRC.ts

   Line 210 in 0b542be

   : `// Stylistic concerns that don't interfere with Prettier

3. Tests for ☝️ (createESLintRC.test.ts)

[DerTimonius]

I would love to take this!

[github-actions]

🎉 This is included in version v1.36.0 🎉

The release is available on:

• GitHub releases
• npm package (@latest dist-tag)

Cheers! 📦🚀