Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lint): add no-useless-rename and object-shorthand #944

Merged
merged 2 commits into from
Oct 8, 2023
Merged

feat(lint): add no-useless-rename and object-shorthand #944

merged 2 commits into from
Oct 8, 2023

Conversation

DerTimonius
Copy link
Contributor

PR Checklist

Overview

This PR adds the following rules to the ESLint config:

The rules have also been added to the created .eslintrc files and the test has been updated. Lint errors have been solved.

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #944 (c68b615) into main (316508f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #944   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files          91       91           
  Lines        4850     4852    +2     
  Branches      405      405           
=======================================
+ Hits         4533     4535    +2     
  Misses        316      316           
  Partials        1        1
Flag Coverage Δ
create 71.18% <100.00%> (+0.01%) ⬆️
initialize 38.17% <33.33%> (-0.02%) ⬇️
migrate 70.03% <100.00%> (+0.01%) ⬆️
unit 68.08% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/shared/options/ensureRepositoryExists.ts 93.33% <100.00%> (ø)
src/steps/writing/creation/createESLintRC.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 8, 2023
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha this is great, thanks! Twice as much linting as I'd expected 😄

@JoshuaKGoldberg JoshuaKGoldberg merged commit 4184d1b into JoshuaKGoldberg:main Oct 8, 2023
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @DerTimonius for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this pull request Oct 8, 2023
Merged
@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @DerTimonius! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

🎉 This is included in version v1.36.0 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg pushed a commit that referenced this pull request Oct 8, 2023
@allcontributors
docs: add dertimonius as a contributor for code (#946)
2ea9d87 
Adds @DerTimonius as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#944 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@DerTimonius DerTimonius deleted the patch-1 branch October 27, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Enable no-useless-rename
2 participants
@DerTimonius @JoshuaKGoldberg