feat: populate existing cspell.json words during migration #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1208 +/- ##
==========================================
+ Coverage 94.33% 94.73% +0.39%
==========================================
Files 99 103 +4
Lines 5666 5715 +49
Branches 462 473 +11
==========================================
+ Hits 5345 5414 +69
+ Misses 320 300 -20
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Test failures are unrelated. #877 |
|
🎉 This is included in version v1.54.0 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Runs
pnpm lint:spellingand matchesUnknown word (...)complaints.Also standardizes two things in code that were bugging me:
node:fs/promisesimports asimport * as fsformatJsoninstead of manuallyprettier.formatcallsThis finally means that the file creator for
cspell.jsonno longer needs to prepopulate with a static list of words. So unnecessary ignored words will no longer be potentially introduced by that. Yay.