-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add options.type #2112
feat: add options.type #2112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2112 +/- ##
=======================================
Coverage 99.80% 99.80%
=======================================
Files 127 127
Lines 5214 5238 +24
Branches 361 369 +8
=======================================
+ Hits 5204 5228 +24
Misses 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
😬 JoshuaKGoldberg/package-json-validator#178 is failing linting with:
Sigh. I'll have to add some |
🎉 This is included in version v2.23.0 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
"commonjs"
#2111status: accepting prs
Overview
Goes a different, more comprehensive direction than #2110. Instead of encouraging a
blockPackageJson
it promotestype
to a top-level option.--type commonjs
will now work if a user really wants.blockESLint
will now print its config aseslint.config.mjs
ifoptions.type
is"commonjs"
. It's stilleslint.config.js
otherwise.🎁