feat: run ESLint and Prettier fixers in hydration #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #514 +/- ##
==========================================
+ Coverage 86.86% 87.10% +0.23%
==========================================
Files 54 55 +1
Lines 2901 2947 +46
Branches 117 121 +4
==========================================
+ Hits 2520 2567 +47
+ Misses 378 377 -1
Partials 3 3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JoshuaKGoldberg
commented
Jun 7, 2023
| @@ -9,7 +11,8 @@ export async function getDefaultSettings() { | |||
| .pipeStdout?.($({ stdin: "pipe" })`grep origin`) | |||
| .pipeStdout?.($({ stdin: "pipe" })`grep fetch`); | |||
| } catch { | |||
| console.log( | |||
| logLine(); | |||
| logLine( | |||
There was a problem hiding this comment.
Couldn't resist this little cleanup 😄
|
🎉 This is included in version v1.28.8 🎉 The release is available on: Cheers! 📦🚀 |
1 similar comment
|
🎉 This is included in version v1.28.8 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Per the issue, runs
pnpm lint --fixnear the end of hydration. Also runspnpm format --write. For both, if there was an error, the user is warned to run the command themselves.Rewords from "Succeeded" to "Passed" for spinner blocks to indicate that there might not have been a total success.